Skip to content

fix: from FIXME(#24570) added more info #148156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: from FIXME(#24570) added more info #148156

wants to merge 4 commits into from
+10 −1

Conversation

@WrldEngine
Copy link

@WrldEngine WrldEngine commented Oct 26, 2025 •
edited by rustbot
Loading

Added more info from FIXME(#24570)

#24570 (comment)
Added fields like from unix version of rustc: read/write flags
And other additional field for debug.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Sign in to view
hkBst
hkBst reviewed Oct 27, 2025
View reviewed changes
hkBst
hkBst suggested changes Oct 27, 2025
View reviewed changes
Copy link
Member

@hkBst hkBst left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

View changes since this review

@WrldEngine @hkBst
chore: library/std/src/sys/fs/windows.rs
33fbf38 
Co-authored-by: Marijn Schouten <hkBst@users.noreply.github.com>
@WrldEngine
Copy link
Author

@hkBst Should you add labels for windows, or is this unnecessary for this time?

@hkBst
Copy link
Member

hkBst commented Oct 27, 2025 •
edited
Loading

@WrldEngine yes, I will, but you can do it yourself too.

@rustbot label O-windows
r? @ChrisDenton

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

ChrisDenton is not on the review rotation at the moment.
They may take a while to respond.

@WrldEngine
Copy link
Author

@WrldEngine yes, I will, but you can do it yourself too.

@rustbot +labels O-windows

r? @ChrisDenton

Got it. I thought that is the permission-related

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WrldEngine
Copy link
Author

@rustbot +labels O-windows

@rustbot rustbot added the O-windows Operating system: Windows label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hkBst hkBst hkBst requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrisDenton ChrisDenton

Labels

O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@WrldEngine @rustbot @hkBst @rust-log-analyzer @ChrisDenton @Mark-Simulacrum